luckyframework / luckyframework/avram
Utilize the verify_connection task more
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
We call this task before the [db.dump](https://github.com/luckyframework/avram/blob/master/src/avram/migrator/runner.cr#L117) already. We should also do this for all of our built in tasks that require connecting to the DB. Also, maybe this should be moved to the actual task itself, then you have the ability to call to these methods manually and skip the connection checking, but when you run the task, it would do it for you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/avram/migrator/runner.cr around line 117, where db.dump already calls verify_connection, and identify the other built-in tasks that connect to the database. Review how those tasks are invoked and define completion as consistent connection checking while preserving the proposed ability to call task methods manually without it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal, postgres
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100