luckyframework / luckyframework/avram
Avram::Model#reload passes <Model>::BaseQuery to its block, should pass <Model>Query
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
For my `Language` model, `Avram::Model#reload` passes `Language::BaseQuery` to its block instead of `LanguageQuery`. Thus, when I try to use the `LanguageQuery#preload_parents` method which I added, I get this:
```
In src/operations/mixins/hierarchical_operation.cr:10:20
10 | o = o.reload(&.preload_parents.preload_url_path)
^--------------
Error: undefined method 'preload_parents' for Language::BaseQuery
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Avram::Model#reload and trace the query object passed to its block. Reproduce the failure from src/operations/mixins/hierarchical_operation.cr:10 using LanguageQuery#preload_parents, then verify that reload supplies LanguageQuery so the operation compiles and the preload chain works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100