luckyframework / luckyframework/avram
Figure out how to better handle dates
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Crystal only has a `Time` class. How should LuckyRecord handle dates?
One way this could be done is to create a `LuckyRecord::Date` class that can be used and sets the time to 00:00:00. It would be stored to the db as a time.
Alternatively it would save to the db as a date. I'll have to think that through a bit more though. I'm open to suggestions if anyone has some thoughts about this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by tracing how existing Time values are represented and persisted, then compare the proposed normalized-Time and database-date approaches. Done means a decided date model with defined storage behavior and coverage for reading and writing dates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal, postgresql
- Domain
- database
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100