luckyframework / luckyframework/avram

Add `is_filled` to Criteria

Open
#344 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Crystal
Stars
183
Forks
67
PR merge metrics
No merged PRs in 30d

Description

An alias `is_not_nil`. Reveals the intent of the query better

```crystal
UserQuery.new.banned_at.is_present
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Criteria entry point and its existing is_not_nil and is_present predicates. Confirm whether the requested name is is_filled and which existing predicate it should alias, then verify the UserQuery example expresses the intended query behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
database
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.