luckyframework / luckyframework/avram
Luckyform treats nullable has_one fillable as required fillable
Open
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Reproduce
Put a nullable has_one field to model
Make it fillable for the form (***_id)
make a visible form with text_input
submit the form with blank text_input
and LuckyForm complains the validity of the field.
I hope it can respect the nullable nature of the model.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the nullable has_one form case described in the issue, then locate LuckyForm's validation path for fillable association IDs. Done means submitting a blank text_input for a nullable has_one field no longer reports the field as invalid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100