luanti-org / luanti-org/contentdb
.gitattributes export-subst doesn't work correctly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 115
- Forks
- 62
- Avg merge
- 19h 7m
- Merged PRs (30d)
- 5
Description
Summary
.gitattributes export-subst are not being handled at all by git-export-all (upstream issue https://github.com/Kentzo/git-archive-all/issues/81). No progress on this is evident, and the git-export-all author's approach of having to recreate all git features is ultimately doomed to suffer more of these sorts of issues in the future.
As a workaround, we should at least allow use of plain git exports when the package doesn't contain any submodules, as probably applies to most packages, and especially to the ones I know are affected (the NodeCore ones).
Steps to reproduce
- Create a release for NodeCore or NodeCore Alpha (or look at any of the releases already on CDB).
- Run the game and open up the "inventory" screen (about dialog).
Expected:
The version number of the release is listed. These are calculated from a version.lua file that has git export substitutions in it to access the commit metadata at export time.
Observed:
The version is listed as "development/contentdb version" because the substitutions weren't performed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining how git-export-all creates release archives and compare that flow with plain git exports for packages without submodules. Reproduce the issue with a NodeCore or NodeCore Alpha release and inspect version.lua, where git export substitutions are expected. Done means affected releases show their commit-derived version instead of "development/contentdb version".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git
- Domain
- release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100