luadch / luadch/scripts

cmd_pm2offliners.lua - should the settings really be in the core/cfg.lua file?

Open
#41 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
5
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Why is the settings for `cmd_pm2offliners.lua` moved here?

https://github.com/luadch/luadch/blob/f048b4b330b3bc708d9163d4f03b7fec229f6655/core/cfg.lua#L1644

If the hubowner want to change the min level he need to edit this file and is that something you recommend him to do?

Files in the core folder are not files you should edit manual.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading cmd_pm2offliners.lua and the referenced section of core/cfg.lua around line 1644. Trace how the minimum level is loaded and determine how hubowners are expected to configure it. Done means the setting no longer requires manually editing a core file, with the configuration behavior documented or tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.