lspitzner / lspitzner/brittany

Parsing error on comments on type definition within instance declaration

Open
#282 0 comments 0 reactions 1 assignee View on GitHub

@lspitzner is already working on this.

Since Feb 17, 2020.

bug hs:comments hs:types
Dominant language
Haskell
Stars
686
Forks
69
PR merge metrics
No merged PRs in 30d

Description

I noticed an issue with brittany's comment parsing in the following:

instance HasDependencies SomeDataModel where
  -- N.B. Here is a bunch of explanatory context about the relationship
  -- between these data models or whatever.
  type Dependencies SomeDataModel
    = ( SomeOtherDataModelId
      , SomeOtherOtherDataModelId
      )

@eborden mentioned I should drop an issue here and that this should be an easy case to add a test for and address. Let me know if you need any help reproducing!

FWIW, I just skirted the issue by promoting the comment to be outside of the instance declaration. Not a high priority fix for me or else I'd probably dive in :) Just wanted to make sure it was tracked somewhere.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.