lsongdev / lsongdev/node-escpos

qrcode commands seem to be wrong

Open
#427 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.6k
Forks
443
PR merge metrics
No merged PRs in 30d

Description

https://github.com/song940/node-escpos/blob/d04f2b0c99b5bbbfde6100e2ed2f92f9be37db46/packages/printer/src/commands.ts#L180-L202

As can be shown here:
\x1d\x28\x6b\x03\x00\x31\x43 is used for version but as it can be seen [here]: x43 is for size of module
on the other hand x41 is for the model which is I guess what you mean by version.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect packages/printer/src/commands.ts at lines 180-202 and compare the QR-code command bytes with the linked Epson ESC/POS reference. Confirm the meanings of x43 and x41, then update the QR-code command definitions so their parameters match the documented protocol and verify the resulting command sequences.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.