lsongdev / lsongdev/node-escpos
Wrong ESCPOS command for Italic on and Italic off
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.6k
- Forks
- 443
- PR merge metrics
- No merged PRs in 30d
Description
File: command.js
TXT_ITALIC_OFF: '\x1b\x35', // Italic font ON
TXT_ITALIC_ON: '\x1b\x34', // Italic font ON
It should be
TXT_ITALIC_OFF: '\x1b\x34\x00', // Italic font OFF
TXT_ITALIC_ON: '\x1b\x34\x01', // Italic font ON
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open command.js and inspect the TXT_ITALIC_OFF and TXT_ITALIC_ON constants. Compare their escape sequences and comments with the issue description; the work is done when both constants use the requested values and their comments correctly describe italic off and on.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100