lsongdev / lsongdev/node-bluetooth

[BUG]: Can't build on windows 11 : missing function arguments

Open
#61 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
205
Forks
56
PR merge metrics
No merged PRs in 30d

Description

Description of the bug

Installed with Yarn on electron-vite project on windows 11
Yarn install says node-bluetooth@npm:1.2.6 must be built because it never has been before or the last one failed
then build fails with error :
...\node_modules\node-bluetooth\src\windows\DeviceINQ.cc(128,60): error C2660: 'v8::FunctionTemplate::GetFunction' : function doesn't take 0 arguments

Steps To Reproduce

In fresh electron-vite project :

  • choco install python visualstudio2022-workload-vctools -y
  • yarn add -d electron-rebuild
  • yarn add node-bluetooth bindings
Additional Information

Yarn add result :

node-bluetooth@npm:1.2.6 must be built because it never has been before or the last one failed
node-bluetooth@npm:1.2.6 couldn't be built successfully (exit code 1, logs can be found here: ...\AppData\Local\Temp\xfs-158d74f1\build.log)

build.log :
each of the following errors happen multiple times, with a lot of warnings I didn't paste here

...\node_modules\node-bluetooth\src\windows\DeviceINQ.cc(128,60): error C2660: 'v8::FunctionTemplate::GetFunction' : function doesn't take 0 arguments

...\node_modules\node-bluetooth\src\windows\DeviceINQ.cc(336,30): error C2665: 'v8::String::Utf8Value::Utf8Value' : no overloaded function could convert all the argument types

...\node_modules\node-bluetooth\src\windows\DeviceINQ.cc(416,32): error C2661: 'v8::Object::Set' : no overloaded function takes 2 arguments

...\node_modules\node-bluetooth\src\windows\DeviceINQ.cc(522,9): error C2660: 'v8::Function::Call' : function doesn't take 3 arguments

gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Current\Bin\MSBuild.exe` failed with exit code: 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure in a fresh electron-vite project using the listed Yarn and Windows setup, then inspect src/windows/DeviceINQ.cc alongside the build.log errors. The work is done when node-bluetooth builds successfully on Windows 11 without the reported V8 API errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, electron, node.js
Domain
build-system, embedded-iot
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.