refactoring `src/theme/icons.rs`
Open
Nobody has claimed this yet.
kind/enhancement
- Dominant language
- Rust
- Stars
- 16.2k
- Forks
- 510
- PR merge metrics
- No merged PRs in 30d
Description
Directly using emojis
would it be useful to directly use emoji?
impl Default for ByType {
fn default() -> ByType {
ByType {
dir: "".into(), //
file: "".into(), //
pipe: "".into(), //
socket: "".into(), //
executable: "".into(), //
symlink_dir: "".into(), //
symlink_file: "".into(), //
device_char: "".into(), //
device_block: "ﰩ".into(), // ﰩ
special: "".into(), //
}
}
}
Compiletime Hashset
using phf set could help with storing duplicate default values
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the linked ranges in src/theme/icon.rs; the issue title refers to src/theme/icons.rs, so resolve that path discrepancy first. Clarify whether the goal is direct emoji defaults, a compile-time phf set, or both, then verify the chosen refactor preserves the default icon values and duplicate handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100