Change default colours used
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.2k
- Forks
- 510
- PR merge metrics
- No merged PRs in 30d
Description
Now that https://github.com/Peltoche/lsd/pull/452 is merged, users should be able to change the colors for `lsd` to what they like. That said, I was thinking we should probably consider changing the default colors that lsd uses to work in both light and dark colorschems. Using colors less that 16 and avoiding yellow should more or less take care of that. This change is only necessary in the non filename blocks as the filename ones are already using colors from `lscolors` which works in both cases. This will require changes in user,group and size blocks.
My only concern here is that existing users will have a change in colors if they are not using a custom theme(it a bit better now that they can change back). Just posting it here to get other's thoughts.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the color configuration introduced by pull request #452 and trace how the user, group, and size blocks select their default colors. Compare the current defaults with the stated light- and dark-colour-scheme constraints, then verify that filename colors remain delegated to lscolors and that existing custom themes are unaffected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100