remove the daed code(NoLscolors) for testing
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.2k
- Forks
- 510
- PR merge metrics
- No merged PRs in 30d
Description
after https://github.com/Peltoche/lsd/pull/452 merged, the themeOption::NoLscolor is only used for testing, it is warned as dead code in Clippy, we currently mark it allowed, and it should be improved to drop the dead code.
maybe we could:
- add a new LSCOLORS for testing
- use a different way for color testing
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the changes in pull request #452 and locate the remaining ThemeOption::NoLscolor uses in the current testing code. Compare the proposed LSCOLORS approach with an alternative color-testing method; done means the dead code and its allow annotation can be removed without losing color-test coverage or triggering the Clippy warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100