lsd-rs / lsd-rs/lsd

how theme should cowork with LSCOLORS

Open
#551 0 comments 0 reactions 0 assignees View on GitHub
kind/discussion kind/enhancement
Dominant language
Rust
Stars
16.2k
Forks
510
PR merge metrics
No merged PRs in 30d

Description

after https://github.com/Peltoche/lsd/pull/452 merged, we support the color theme, but we use [LSCOLORS](https://github.com/trapd00r/LS_COLORS) in the meantime, currently, we check lscolors before the file-type part in theme.

I would like to discuss that:
1. should we have a flag to disable the LSCOLORS and use all the theme configurations?
2. should we have a filename or file-path based theme configuration like LSCOLORS

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the color-theme changes in pull request #452 and the current interaction with LSCOLORS described in the issue. Clarify whether disabling LSCOLORS and adding filename or path-based theme configuration are required, then document the agreed behavior and acceptance criteria before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.