lpil / lpil/rustexp

Support non-unicode flag

Open
#10 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Rust
Stars
130
Forks
20
PR merge metrics
No merged PRs in 30d

Description

It would be cool to support the `regex::bytes::Regex` matcher using the non-unicode flag. If I try this regex:

(?-u).

I get the following error:

```
Syntax(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
regex parse error:
(?-u).
^
error: pattern can match invalid UTF-8
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)
```

In fact you may just want to use the `regex::bytes::Regex` unconditionally.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies the regex::bytes::Regex matcher and the reproducing pattern (?-u).; start by locating where the matcher is constructed and run this pattern in the browser editor. Done means non-Unicode patterns are accepted without the reported invalid UTF-8 error, while existing regex behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.