lowRISC / lowRISC/riscv-llvm

Updates to README.md regarding baremetal.patch

Open
#63 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
277
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Based on the status of [patch D46822](https://reviews.llvm.org/D46822) -- which appears to be accepted, closed, and committed to upstream as of July 31, 2018 -- is this step under [How can I build upstream LLVM+Clang...](https://github.com/lowRISC/riscv-llvm#how-can-i-build-upstream-llvmclang-and-use-it-to-cross-compile-for-a-riscv32-target) still required?

```
wget https://reviews.llvm.org/D46822?download=true -O baremetal.patch
patch -p0 < baremetal.patch
```

When I attempted to apply the patch, I got the dreaded "Reversed (or previously applied) patch detected!" error from `patch`. It seems the patch's contents are now all in the upstream source.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read README.md under “How can I build upstream LLVM+Clang...” and review the linked patch status before following the wget and patch commands. Verify the current build instructions, then update the README so it accurately reflects whether baremetal.patch is still required.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.