lowRISC / lowRISC/opentitan

[rstmgr] module reset detection improvements

Open
#7,780 5 comments 0 reactions 2 assignees View on GitHub

@matutem is already working on this.

Since Feb 18, 2024.

Earlgrey-PROD Triaged Type:FutureRelease
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

We should improve the reset detection scheme to be automatic.
Right now, the resets for each module is manually declared, and the user needs to make sure to pick both the reset with the right root and the right clock domain.

The second part can be error prone and has seen issues surfaced in a few places.

However, given that clocks / resets are always defined as a pair in module hjson, we should just ask the top level declaration to declare the root reset, and auto detect what the appropriate clock domain would be.

This would make the construction correct by design instead of requiring detailed user input.

In addition, since certain modules (ast) now need nested domain support, we should also account for this in the reset construction.
see #7980

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.