[sram_ctrl] Consider refactoring tlul_adapter_sram
Open
@rswarbrick is already working on this.
Since Nov 30, 2021.
Component:RTL
Earlgrey-PROD Triaged
IP:sram_ctrl
Priority:P3
Type:Cleanup
Type:FutureRelease
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
This module has grown quite a bit over time and seems a bit difficult to read and debug by now.
Also, the byte write logic inside `tlul_sram_byte` needs additional request FIFOs which could potentially be consolidated with the rest of the `tlul_adapter_sram` FIFOs if we were to refactor this module.
In addition to the above, also consider creating different wrapper versions of the module to simplify the parameter usage.
Currently there are too many parameters controlling whether integrity is checked, generated or passed through. This makes usage of `tlul_adapter_sram` error prone, as was observed in #9406
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.