lowRISC / lowRISC/opentitan

[i3c] Clean Verible lint

Open
#31,045 0 comments 0 reactions 2 assignees Claimed by @alees24 View on GitHub
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

The `i3c` IP currently has multiple lint violations in Verible. For instance, running
```
verible-verilog-lint \
--rules_config=hw/lint/tools/veriblelint/lowrisc-styleguide.rules.verible_lint \
--waiver_files=verible_waiver hw/ip/i3c/rtl/*.sv
```
on PR #30972 gives:
```
hw/ip/i3c/rtl/i3c_consts_pkg.sv:145:31-53: Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?)|([A-Z_0-9]+) [Style: constants] [parameter-name-style]
hw/ip/i3c/rtl/i3c_consts_pkg.sv:147:31-58: Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?)|([A-Z_0-9]+) [Style: constants] [parameter-name-style]
hw/ip/i3c/rtl/i3c_reg_top.sv:10755:101: Line length exceeds max: 100; is: 101 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_reg_top.sv:10763:101-110: Line length exceeds max: 100; is: 110 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_reg_top.sv:10779:101: Line length exceeds max: 100; is: 101 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_reg_top.sv:10795:101-112: Line length exceeds max: 100; is: 112 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_reg_top.sv:10811:101-108: Line length exceeds max: 100; is: 108 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_reg_top.sv:10827:101-109: Line length exceeds max: 100; is: 109 [Style: line-length] [line-length]
hw/ip/i3c/rtl/i3c_target.sv:665:101-107: Line length exceeds max: 100; is: 107 [Style: line-length] [line-length]
```

Not urgent or critical for functionality, but needs to be cleaned up.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.