lowRISC / lowRISC/opentitan

[tl_reg_adapter] Fix bus2reg to throw an error when d_error is returned

Open
#31,002 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

Description

tl_reg_adapter::bus2reg only reports UVM_NOT_OK when the request didn't complete, it never looks at d_error, so an unmapped access still comes back OK. That also means the uvm_reg::read + status approach can't work. It'll need an expected-error knob in csr_utils to go with it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing tl_reg_adapter::bus2reg and how it handles d_error versus UVM_NOT_OK. Then inspect csr_utils and the uvm_reg::read status path to understand the expected-error requirement. Done means unmapped accesses report an error and expected errors can be handled through csr_utils.

Written by the indexing model from the issue text.

Assessment

Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.