[opentitanlib] Boot services parser validation
@cfrantz is already working on this.
Since Jul 10, 2026.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
### Description
The following code has a couple of bugs that should be fixed:
https://github.com/lowRISC/opentitan/blob/0e4b8d4a77188986ef616e34fe0bb3cade66b387/sw/host/opentitanlib/src/chip/boot_svc.rs#L218-L222
1. The hash is computed over the header, it also should be computed over the payload
2. The comparison is inverted, if the digest match, an error is returned
Moreover, in this line of code:
https://github.com/lowRISC/opentitan/blob/0e4b8d4a77188986ef616e34fe0bb3cade66b387/sw/host/opentitanlib/src/chip/boot_svc.rs#L350
we parse the identifier but never check whether it actually is a valid one.
Thanks to @flaviens for reporting this!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.