lowRISC / lowRISC/opentitan

[lc_ctrl] Untested port interaction combinations in state decode and state transition

Open
#29,968 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

## Description

Coverage analysis identified 7 untested port interaction combinations
across two modules:

**lc_ctrl_state_decode** (3 gaps):
- `lc_state_valid_i=0` with `secrets_valid_i=1`
- `lc_state_valid_i=1` with `lc_state_i` at boundary values
- `secrets_valid_i=0` with `fsm_state_i` in non-idle states

**lc_ctrl_state_transition** (4 gaps):
- `volatile_raw_unlock_i=1` with `trans_cmd_i` at invalid values
- `trans_target_i` at boundary values combined with `dec_lc_state_i=0`
- `lc_cnt_i` at maximum value during transition
- `trans_cmd_i` issued with `fsm_state_i` in error state

## Impact

These input combinations have never been exercised in the verification
suite. Bugs on these paths would not be caught by regression.

## Suggested Fix

Add directed tests for each combination listed above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the verification tests for lc_ctrl_state_decode and lc_ctrl_state_transition and read their existing coverage patterns. Add directed tests for the seven listed combinations, then run the relevant regression and confirm coverage closes for each gap.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.