[aes] Todos following upstreaming of support for GCM
@vogelpi is already working on this.
Since Dec 23, 2025.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
### Description
With #28870, we have started upstreaming support for GCM in the AES hardware IP block. To ease that effort and reduce the amount of rebasing (there are going to be more than 20 PRs), we aim to first upstream the existing implementation and then implement changes on top of the upstreamed implementation.
The purpose of this issue is to collect points and reference comments which need addressing after upstreaming.
- [ ] Make it more explicit in `aes.hjson` and register documentation that the context cannot be saved right after initialization https://github.com/lowRISC/opentitan/pull/28870#discussion_r2597825507
- [ ] Consider introducing a named constant for the width of the `num_valid_bytes` register value instead of using the hardcoded value `4:0` https://github.com/lowRISC/opentitan/pull/28870#discussion_r2598045788
- [ ] Fix typos in RTL comments:
- [ ] https://github.com/lowRISC/opentitan/pull/28943#discussion_r2623590810
- [ ] https://github.com/lowRISC/opentitan/pull/28943#discussion_r2623590810
- [ ] https://github.com/lowRISC/opentitan/pull/28943#discussion_r2623595133
- [ ] https://github.com/lowRISC/opentitan/pull/28943#discussion_r2623604935
- [ ] Consider giving the three correction terms inside the GHASH module a name or variable to make it easier to reference them, e.g., in the documentation, RTL, figures etc.: https://github.com/lowRISC/opentitan/pull/28943#discussion_r2623586431
- [x] Switch AES-GCM code to device tree, see https://github.com/lowRISC/opentitan/pull/29103#discussion_r2689144338, done in #19139
- [ ] Add GCM pentest code to pentest testing framework https://github.com/lowRISC/opentitan/pull/29104#discussion_r2689173999
- [ ] Correct indentation of comments in [hw/ip/aes/rtl/aes_control_fsm.sv](https://github.com/lowRISC/opentitan/pull/29116/changes/BASE..7f09cec0402279573e55fb2e817c9ef10667a125#diff-d447a646a72be3e16ed7e1b53242ee7fdbc2b5dc9080326de39ce998f98724e9), see https://github.com/lowRISC/opentitan/pull/29116/changes/BASE..7f09cec0402279573e55fb2e817c9ef10667a125#r2693472935
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.