Orchestrator python argument parsing uses redundant options
Nobody has claimed this yet.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
Nit: (on original PR, not backport code) - You don't need `default=False` for an argparse argument with `action="store_true"`. See the [docs](https://docs.python.org/3/library/argparse.html#action):
> `'store_true'` and `'store_false'` - These are special cases of `'store_const'` that respectively store the values `True` and `False` with default values of `False` and `True`:
Looking at the orchestrator, it seems like this is repeated for many fields here.
_Originally posted by @AlexJones0 in https://github.com/lowRISC/opentitan/pull/28878#discussion_r2592043768_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the orchestrator's argparse argument definitions and review fields using action="store_true" with an explicit default=False. Remove the redundant options consistently, then verify that the parser behavior remains unchanged using any existing orchestrator tests or parser checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100