[qemu,bazel,sw] Make qemu.bzl multitop aware
Nobody has claimed this yet.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
qemu.bzl is currently hard-coded for Earlgrey, specifically for the OTP map but also for the LC definition file:
This seems wrong. I would instead introduce a top attribute (like in #27169 for OTP) which points to the require filed. That being said, the QEMU rule already another default dependency on earlgrey so we could just add it to the multitop tracking issue #26116
Originally posted by @pamaury in https://github.com/lowRISC/opentitan/pull/27950#discussion_r2284529558
This should be circumvented and the rule should take the top information into account.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading qemu.bzl and trace its Earlgrey-specific OTP map and LC definition dependencies. Compare the top attribute approach discussed in #27169 and the multitop context in #26116. Done means the QEMU rule uses the selected top information rather than being hard-coded for Earlgrey.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100