lowRISC / lowRISC/opentitan

check-countermeasures fails for Darjeeling & checks disabled for lc_ctrl

Open
#26,362 3 comments 0 reactions 1 assignee Assigned to @andreaskurth View on GitHub
Component:Darjeeling IP:lc_ctrl
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### desc

All tops except darjeeling pass the [check-countermeasures.sh](https://github.com/lowRISC/opentitan/blob/master/ci/scripts/check-countermeasures.sh) check. The purpose of this script is to check, whether all countermeasure labels defined in the hjsons are present in the RTL. Discovered in #26361.

```bash
./ci/scripts/check-countermeasures.sh darjeeling
ERROR: Hjson countermeasure PRIM_RAM.CTRL.MUBI declared in Hjson file sram_ctrl.hjson doesn't appear in the RTL.
ERROR: Block sram_ctrl: Some countermeasures in Hjson don't appear in RTL.
ERROR: Hjson countermeasure KMAC_IF_DONE.CTRL.CONSISTENCY declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure KMAC_IF.FSM.SPARSE declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure KMAC_IF_CMD.CTRL.CONSISTENCY declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure SIDE_LOAD_SEL.CTRL.CONSISTENCY declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure DATA.FSM.SPARSE declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure SIDELOAD_CTRL.FSM.SPARSE declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure CTRL.FSM.CONSISTENCY declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure KMAC_IF.CTR.REDUN declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Hjson countermeasure RESEED.CTR.REDUN declared in Hjson file keymgr_dpe.hjson doesn't appear in the RTL.
ERROR: Block keymgr_dpe: Some countermeasures in Hjson don't appear in RTL.
ERROR: No Hjson countermeasure FSM.SPARSE exists for RTL reference at /home/pascal/Documents/projects/sram_ctrl_cm/opentitan/hw/ip/soc_dbg_ctrl/rtl/soc_dbg_ctrl.sv, line 372.
ERROR: No Hjson countermeasure DEBUG_POLICY_CATEGORY.CONFIG.SHADOW exists for RTL reference at /home/pascal/Documents/projects/sram_ctrl_cm/opentitan/hw/ip/soc_dbg_ctrl/rtl/soc_dbg_ctrl.sv, line 125.
ERROR: Hjson countermeasure DEBUG_POLICY_RELOCKED.CONFIG.SHADOW declared in Hjson file soc_dbg_ctrl.hjson doesn't appear in the RTL.
ERROR: Block soc_dbg_ctrl: Some unknown and some missing countermeasures in RTL
ERROR: Countermeasure checks failed.
::error::Countermeasure check failed.
```

To prevent CI failures with the changes in PR #27946, countermeasure checks for `lc_ctrl` (also for other tops) have been disabled in that PR.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.