lowRISC / lowRISC/opentitan

[ipgen,pkg] Split generic objects out of the ipgen packages

Open
#25,921 0 comments 0 reactions 3 assignees View on GitHub

@matutem is already working on this.

Since Jan 17, 2025.

Component:RTL
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

Description

There are a number of objects provided by ipgen IPs that are independent of any parameterization, and are used by generic IPs for ports types. This requires the generic IPs to use the virtual interface to ipgen IP packages, which is troublesome.

In otp_ctrl this was resolved by splitting all top specific items objects out of the otp_ctrl_pkg, and moved to a template otp_ctrl_top_specific_pkg. A solution of this sort can be used for other ipgen IPs as well.

It is equally sensible to move the declarations of the generic objects to the receiving IP's pkg, if there is a single generic receiver. A better solution could be to place these generic objects to a better location, perhaps under hw/common.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.