[RACL] Improve error checking when parsing a RACL config
@Razer6 is already working on this.
Since Dec 18, 2024.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
https://github.com/lowRISC/opentitan/pull/25664 adds the initial part of the RACL implementation. This confidently parses the RACL config without much error checking. This should be improved over time but should allow the functional implementation to continue.
I'd strongly suggest putting a tiny bit more type checking in here. Something like extracting `roles` and `policies` as a list / dictionary, respectively (doing a basic type check) and maybe checking the item and key/value types for them respectively.
Extracting that properly will get rid of the dictionary lookups lower down in the function.
_Originally posted by @rswarbrick in https://github.com/lowRISC/opentitan/pull/25664#discussion_r1889245090_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.