lowRISC / lowRISC/opentitan

[fpv,pinmux] Can we keep a single fpv pinmux_tb

Open
#24,843 1 comment 0 reactions 7 assignees Claimed by @vogelpi View on GitHub
Component:FPV IP:pinmux
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### Description

The fpv flow for pinmux has two testbench tops

- hw/ip/pinmux/fpv/tb/pinmux_tb.sv
- hw/top_earlgrey/ip_autogen/pinmux/tpv/tb/pinmux_tb.sv

They differ in various mio and dio attributes, mostly pad_type and scan_role. The one under top_earlgrey assigns these attributes per pin, while the one under hw/ip makes a blanket assignment to all mio and dios.

I will preserve this dichotomy when transitioning pinmux to ipgen, placing both tb's each with a separate core file under ip_templates, so ip_autogen will keep them. However, I wonder why we need to have both at all. There are a few contributors to these files, most significantly @cindychip and @msfschaffner, and their feedback would be valuable. However, both have transitioned to other principal projects.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.