lowRISC / lowRISC/opentitan

[adc_ctrl] Documentation of recommended ChromeOS detection ranges are insufficient

Open
#24,719 0 comments 0 reactions 2 assignees Claimed by @msfschaffner View on GitHub
Component:Doc IP:adc_ctrl
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### Description

The documentation recommends how to program the `adc_chnX_filter_ctlN` registers, in order to detect voltage combinations as outlined in a diagram: https://opentitan.org/book/hw/ip/adc_ctrl/doc/programmers_guide.html

However, as far as I can tell, the listed values fail to take into account the error tolerance of the ADC itself (either +/- 30 mV or +/- 15 mV). That is, in order to e.g. recognize the voltage being in the range 400mV - 600mV, it is not good enough to calculate the ADC count corresponding to 400mV and to 600mV. We need instead to set the limits at 400mV - 15mV and 600mV + 30mV, to take into account the possible error introduced by the ADC itself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.