lowRISC / lowRISC/opentitan

[hmac/dv] Remove/replace checks from the sequences

Open
#23,288 1 comment 0 reactions 1 assignee View on GitHub

@martin-velay is already working on this.

Since May 23, 2024.

Component:DV IP:hmac
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### Description

The sequences are not supposed to perform checks, that's the job of the scoreboard. This constraint comes from the UVM itself, we should build reusable components, the SB can be disabled but not the seq.

Eg: `compare_digest(parsed_vectors[j].exp_digest);` from `hmac_test_vectors_sha_vseq`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.