lowRISC / lowRISC/opentitan

[rv_dm] dmcontrol.haltreq should always read as 0

Open
#23,204 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component:RTL IP:rv_dm Triage Priority Type:Bug
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### desc

The RISC-V spec (v0.13.2) defines the dmcontrol.haltreq bit with access "W" (Section 3.12.2), which is defined as "Write-only. When read this field returns 0" (Table 1.2). However, the current implementation allows this bit to be read as 1 after a write sets it to 1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the rv_dm implementation of dmcontrol.haltreq and the tests covering dmcontrol reads and writes. Compare its behavior with the RISC-V v0.13.2 Section 3.12.2 and Table 1.2 requirements; done means haltreq reads as 0 even after writing it to 1, with regression coverage.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.