regtool: reg_top triggers write error when not writing to a permitted byte, instead of when writing to a forbidden byte
Open
@rswarbrick is already working on this.
Since May 2, 2024.
Component:Doc
Tool:reggen
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
Shouldn't this code check |(reg_be & ~PERMIT[i]), not |(PERMIT[i] & ~reg_be)?
I.e., "if a byte is being written (reg_be[j] = 1) and it is not permitted (PERMIT[i][j] = 0, or ~PERMIT[i][j] = 1), then there's an error."
Currently the error signal seems to be activated when any of the permitted bytes is not being written, instead of when any of the non-permitted bytes is being written.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.