[keymgr_dpe,dv] Check that advance operation is not successful when `retain_parent == true` and destination slot equals source slot
@bobby-rivos is already working on this.
Since Jan 12, 2024.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
Follow up from opentitan-integrated/issues#352:
> The specification already defines that for an *advance* operation to be valid, the destination slot must not be valid when `retain_parent == true` (when `retain_parent == false`, the destination slot must equal the source slot and must be valid). The RTL seems to implement this correctly in the resolution of `invalid_retain_parent`:
https://github.com/lowRISC/opentitan/blob/a40e4c72d43306095fa920aeaf2ab9c92811ff82/hw/ip/keymgr_dpe/rtl/keymgr_dpe_ctrl.sv#L614-L616?plain=1
>
> Thus, the spec and RTL parts of this points are **done**. What remains is checking this in the scoreboard and covering it in a test.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.