lowRISC / lowRISC/opentitan

[bazel] Re-examine use of `kwargs` in implementaion functions

Open
#19,933 1 comment 0 reactions 0 assignees View on GitHub
Priority:P2 SW:Build System Type:Task
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

Currently, many of the low-level transformation functions in the new rules use `kwargs` to accept optional arguments that one would expect to be provided in a rules context object. The reason for this is so that such functions can serve both as rule implemention functions and as utility functions called by other rules. It may be cleaner to explicitly specify all arguments rather than using the current `kwargs` scheme.

Contributor guide

Open the contributing guide

Research direction

Start by locating the low-level transformation and rule implementation functions in the new rules, then trace how their kwargs are passed by rules and utility callers. Done means the argument-passing approach is explicitly defined and consistently supports both use cases without relying on the current kwargs scheme.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.