[util] Make PR approval comments visible to change blocker script
Nobody has claimed this yet.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
### Description
The https://github.com/lowRISC/opentitan/blob/master/ci/scripts/check-pr-changes-allowed.py script which stops changes to files in the BLOCKLIST unless there are 'CHANGE AUTHORIZED: file' comments from a couple of committers cannot see comments that are made as part of a PR approval. I would guess these live in a different place in the github data model vs plain comments so it doesn't pick them up. This should be fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ci/scripts/check-pr-changes-allowed.py and trace how it obtains PR comments and recognizes “CHANGE AUTHORIZED: file” comments. Reproduce the case with an approval comment, then verify that the change blocker recognizes the authorization while preserving its existing behavior for plain comments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- ci-cd, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100