[ujson] CRC incorrect for undeliminated values
Nobody has claimed this yet.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
The CRC values are incorrect when deserialising a bare undeliminated values, such as a single enum.
The C ujson deserialiser reads the trailing newline when deserialising this type, as it has no other way of knowing the last character. This means the deserialilser gets the next whitespace character and the crc calculation includes this character, which is not part of the ujson message so the CRC value is incorrect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the C ujson deserializer and its CRC calculation for a bare undelimited value such as a single enum. Reproduce the case involving the trailing newline or whitespace, then verify with a focused regression test that the CRC covers only the ujson message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100