lowRISC / lowRISC/opentitan

[dv/keymgr] List the unchecked regs

Open
#18,344 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component:DV Earlgrey-PROD Candidate IP:keymgr Milestone:V3 Priority:P3 Type:Cleanup
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

### Description

In keymgr scb. when doing process_tl_access read compare task, some regs are not checked here (they are updated and checked in other timing in the scb).

Reference:
https://cs.opensource.google/opentitan/opentitan/+/master:hw/ip/keymgr/dv/env/keymgr_scoreboard.sv;l=739

I think a better way to do it would be explicitly listed all the regs that are not checked here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at hw/ip/keymgr/dv/env/keymgr_scoreboard.sv around line 739 and inspect the process_tl_access read-compare task. Identify the registers omitted there because they are updated and checked at other times, then explicitly list those registers in the scoreboard. Confirm that the listed registers match the intended checks across the relevant timing paths.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot, security, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.