lowRISC / lowRISC/opentitan

[rom_ctrl/dv] B2B same address read not tested yet

Open
#16,840 5 comments 0 reactions 0 assignees View on GitHub
Earlgrey-PROD Candidate IP:rom_ctrl Priority:P3
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

Rom_ctrl mem TL interface supports 2 outstanding requests.
https://github.com/lowRISC/opentitan/blob/316831f8c2199f2288dd57ac4aeaec3334b5dfb8/hw/ip/rom_ctrl/rtl/rom_ctrl.sv#L193

From the coverage result, looks like we haven't test B2B read on the same address.
Screen Shot 2022-12-14 at 1 36 48 PM

I came across this because I tried to resolve this [TODO](https://cs.opensource.google/opentitan/opentitan/+/master:hw/dv/sv/tl_agent/tl_agent_cov.sv;l=73?q=tl_agent_cov&ss=opentitan%2Fopentitan:hw%2F) which uses a flag to disable above function coverage. Now I think we can probably remove this flag and the TODO as we should always cover 2 outstanding requests use the same address if it do support 2 or more outstanding requests.

cc: @GregAC @msfschaffner

> estimate 4

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the referenced interface logic in hw/ip/rom_ctrl/rtl/rom_ctrl.sv and the coverage TODO in hw/dv/sv/tl_agent/tl_agent_cov.sv. Use the coverage result to identify the missing back-to-back read case for two outstanding requests at the same address. Done means the case is covered and the disabling flag and TODO can be removed if no longer needed.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.