lowRISC / lowRISC/opentitan

[dv,fpv] Automatically add FSM asserts

Open
#16,593 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component:DV Component:FPV Priority:P3 Type:Enhancement Type:FutureRelease
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

For CSRNG and EDN, I added asserts to make sure that error states are stable. These and possibly other asserts could be automatically added to a dedicated FSM macro, especially one that is aware of what is an error state.

The asserts that I am talking about are similar to the ones I added at the bottom of the files in this PR: https://github.com/lowRISC/opentitan/pull/16535/files

This issue is related to the ideas in this issue: https://github.com/lowRISC/opentitan/issues/16572

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the assertions added at the bottom of the files in PR 16535, then read the related ideas in issue 16572. Determine the scope of a dedicated FSM macro and how it should identify error states. Done means the macro automatically adds the required stability assertions for CSRNG, EDN, and any agreed additional FSMs.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.