[otbn,dv] Parameterize `otbn_intg_err` base class
Open
Nobody has claimed this yet.
Component:DV
Earlgrey-PROD Candidate
IP:otbn
Priority:P3
Type:Cleanup
Type:FutureRelease
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
When `otbn_intg_err` got implemented it was explicitly used for injecting integrity errors to bignum registers. Therefore the arguments for the some tasks and functions are written for BigNum lengths. If we can parameterize it, we then don't need to have `otbn_rf_base_intg_err` implement it's own body.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the otbn_intg_err and otbn_rf_base_intg_err definitions and comparing their task and function arguments. Identify the BigNum-length assumptions that need parameterization. Done means the base class supports the required lengths, the derived class no longer needs its own body, and existing integrity-error verification still works.
Written by the indexing model from the issue text.
Assessment
- Domain
- security, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100