lowRISC / lowRISC/opentitan

[kmac] Entropy error code

Open
#15,088 15 comments 0 reactions 0 assignees View on GitHub
Component:Darjeeling Component:Doc Component:RTL IP:kmac Priority:P2 SW:cryptolib Type:Enhancement Type:FutureRelease
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

When reviewing KMAC entropy related error code, here is one concern we want to flag:
There are two KMAC entropy error code: `WaitTimerExpired` and `IncorrectEntropyMode`.
Currently both of them will flag an KMAC error.

However, the concern here is: the current KMAC error does not block any incoming operations.
So with these error, we believe KMAC will continue to process all the incoming operations with the existing entropy.
We think this might have some potential issue and at least we should flag an error on keymgr app interface and stop the process there.

@eunchan please feel free to elaborate more.
@jadephilipoom @johannheyszl @cdgori please let us know if you have any other thoughts.

Thanks,
Cindy

Contributor guide

Open the contributing guide

Research direction

Start by locating the KMAC handling for the WaitTimerExpired and IncorrectEntropyMode errors; the issue does not name files or tests. Trace how these errors reach the keymgr app interface and whether incoming operations continue, then verify that the intended error is surfaced and processing stops as requested.

Written by the indexing model from the issue text.

Assessment

Domain
cryptography, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.