lowRISC / lowRISC/opentitan

Audit CI scripts and Yaml for unwanted exit code clobbering

Open
#14,675 1 comment 0 reactions 1 assignee View on GitHub

@dmcardle is already working on this.

Since Aug 31, 2022.

Component:CI Earlgrey-PROD Triaged Priority:P3
Dominant language
SystemVerilog
Stars
3.6k
Forks
1.1k
Avg merge
2d 22h
Merged PRs (30d)
141

Description

I wonder how we could avoid accidentally clobbering the exit code in the future. We should probably do an audit of other instances of || echo in our CI scripts and Yaml files.

Originally posted by @dmcardle in https://github.com/lowRISC/opentitan/issues/14668#issuecomment-1232964502

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.