CODEOWNERS names users without write access to repo
@dmcardle is already working on this.
Since Jun 30, 2022.
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
https://github.com/lowRISC/opentitan/blob/d8af32ff61026d72a7586c66870feaa162335654/.github/CODEOWNERS
The CODEOWNERS file complains about @drewmacrae, @Jacob-Levy , and @milesdai. For each of them, it says, "Unknown owner: make sure $username exists and has write access to the repository".
Skimming Github's ["About code owners"](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) doc, I don't understand the reason for the error. The doc implies that users only need read access.
> The people you choose as code owners must have read permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.
> Users must have read access to the repository and teams must have explicit write access, even if the team's members already have access.
Possible solutions:
1. Ignore the errors. Is there any value to listing reviewers without write access? Can they be auto-assigned to reviews?
1. Grant write access to these users.
1. Remove the users from CODEOWNERS.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.