[adc_ctrl] remove software facing filter_status
A pull request for this has already been merged.
- #21829 by @msfschaffner — merged
- Dominant language
- SystemVerilog
- Stars
- 3.6k
- Forks
- 1.1k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 141
Description
@timothytrippel
After the recent fix which de-coupled filter status from interrupt status, the only purpose filter_status has left is generating the wakeup.
After discussing with @timothytrippel , we don't have to explicitly have software ack the filter status for wakeup (we can also use the interrupt clear for that).
So I think it would make sense to remove filter status from software view, and use interrupt status clear as the ack.
This is a pretty minor change, but I want to make sure there isn't a huge impact on existing adc_ctrl DV.
@NigelScales please let us know what you think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the adc_ctrl implementation and its existing DV coverage, focusing on how filter_status is exposed and how interrupt status clear acknowledges wakeup. Confirm that the software view no longer exposes filter_status and that the relevant DV remains correct; merged PR #21829 indicates this work has already moved elsewhere.
Written by the indexing model from the issue text.
Assessment
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100