lowRISC / lowRISC/mocha

Clean-up KMAC App Interfaces

Open
#599 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SystemVerilog
Stars
38
Forks
21
Avg merge
2d 23h
Merged PRs (30d)
14

Description

Reduce the number of KMAC App Interfaces from three to one, as the KMAC in Mocha only needs one to perform its sole function of ROM checking.

The KMAC in OpenTitan earlgrey has three App Interfaces, and it was easier during Mocha KMAC integration to maintain that many due to breakages in a primitive used by KMAC when the number of App Interfaces was reduced to one. The unused two App Interfaces were assigned default values.

When we have more time, it would be nice to patch KMAC so it can synthesise with only one App Interface.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Mocha KMAC integration and its App Interface declarations; compare them with the OpenTitan Earlgrey KMAC configuration described in the issue. Confirm that the KMAC has one App Interface, unused interfaces are removed, synthesis succeeds, and ROM checking still works.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.