lowRISC / lowRISC/manticore

GetPfmId Could save having to send identifier type when Version

Open
#153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
17
Forks
11
PR merge metrics
No merged PRs in 30d

Description

The spec for the GetPfmId Request says that the `identifier` field is optional. This is because it defaults to `Identifier::Version` if not provided. We can save sending this field over wire in this case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GetPfmId Request definition and its serialization path. Check how an omitted identifier is represented on the wire, then verify that requests using the default Identifier::Version no longer send the field and that other identifier types remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.