SGE queue name is hard-coded
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 13
- Forks
- 21
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 8
Description
https://github.com/lowRISC/dvsim/blob/9f09c8f9359e8583cb95f2c6c8912bdef34f0c7a/src/dvsim/launcher/sge/launcher.py#L67
This should be configurable.
Also maybe I'm misreading things but there's an entire `SGE` class in `engine.py` which appears to be unused.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/dvsim/launcher/sge/launcher.py line 67 and trace how SGE launcher settings are supplied. Read the SGE class in engine.py to determine whether it is referenced elsewhere. Done means the queue name is configurable and the unused-class question has a documented resolution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100