lowRISC / lowRISC/crt

Reconfigure warnings-related feature flags

Open
#30 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Starlark
Stars
7
Forks
15
PR merge metrics
No merged PRs in 30d

Description

There are a number of feature flags related to compiler warnings:
https://github.com/lowRISC/crt/blob/main/features/common/BUILD.bazel#L45-L113
https://github.com/lowRISC/crt/blob/main/features/embedded/BUILD.bazel#L91-L104

The feature_single_flag_c_cpp macro defaults each feature to enabled.

While these warnings are relevant to the OpenTitan codebase, they are overly-strict for some codebases. I'd prefer to see some of these features disabled by default and explicitly enabled in a project's .bazelrc file with additional --features=... switches.

We should also consider whether we should group these warnings into classes (ie: low, medium, high) and allow enable/disable of each class of warning feature with a single --features=... switch.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the warning feature definitions in features/common/BUILD.bazel and features/embedded/BUILD.bazel, especially the ranges linked in the issue, and inspect how feature_single_flag_c_cpp sets defaults. Determine which warnings should change defaults and whether warning classes are feasible; done requires an agreed configuration and corresponding Bazel feature behavior.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.